1.78 release

FAQ.md

@@ -24,6 +24,8 @@ to prevent Android from killing the service that takes care of receiving and sen
 
 Most, if not all, other email apps don't show a notification with the "side effect" that new email is often not or late being reported.
 
+Background: this is because of the introduction of [doze mode](https://developer.android.com/training/monitoring-device-state/doze-standby) in Android 6 Marshmallow.
+
 <a name="FAQ3"></a>
 **(3) What are operations and why are they pending?**
 
@@ -231,6 +233,16 @@ Browse messages on the server will fetch messages from the email server in real
 when you reach the end of the list of synchronized messages, even when the folder is set to not synchronize.
 You can disable this feature under *Setup* > *Advanced options* > *Browse messages on the server*.
 
+<a name="FAQ25"></a>
+**(25) Why can't I select an image, attachment or a file to export/import?**
+
+If a menu item to select a file is disabled (dimmed),
+likely the [storage access framework](https://developer.android.com/guide/topics/providers/document-provider),
+a standard Android component, is not present,
+for example because your custom ROM does not include it or because it was removed.
+FairEmail does not request storage permissions, so this framework is required to select files and folders.
+No app, except maybe file managers, targetting Android 4.4 KitKat or later should ask for storage permissions because it would allow access to *all* files.
+
 <br>
 
 If you have another question, want to request a feature or report a bug, you can use [this forum](https://forum.xda-developers.com/android/apps-games/source-email-t3824168).

app/build.gradle

@@ -6,8 +6,8 @@ android {
         applicationId "eu.faircode.email"
         minSdkVersion 23
         targetSdkVersion 28
-        versionCode 77
-        versionName "1.77"
+        versionCode 78
+        versionName "1.78"
         archivesBaseName = "FairEmail-v$versionName"
 
         javaCompileOptions {

app/src/main/java/eu/faircode/email/AdapterMessage.java

@@ -125,6 +125,7 @@ public class AdapterMessage extends PagedListAdapter<TupleMessageEx, AdapterMess
         }
 
         private void clear() {
+            vwColor.setBackgroundColor(Color.TRANSPARENT);
             ivFlagged.setVisibility(View.GONE);
             ivAvatar.setVisibility(View.GONE);
             tvFrom.setText(null);

app/src/main/java/eu/faircode/email/FragmentAccount.java

@@ -1033,7 +1033,7 @@ public class FragmentAccount extends FragmentEx {
                                             tilPassword.getEditText().setText(token);
                                         } catch (Throwable ex) {
                                             Log.e(Helper.TAG, ex + "\n" + Log.getStackTraceString(ex));
-                                            Helper.unexpectedError(getContext(), ex);
+                                            snackbar.setText(Helper.formatThrowable(ex));
                                         } finally {
                                             snackbar.dismiss();
                                         }

app/src/main/java/eu/faircode/email/Helper.java

@@ -57,7 +57,6 @@ import java.util.concurrent.ThreadFactory;
 
 import javax.mail.Address;
 import javax.mail.AuthenticationFailedException;
-import javax.mail.FolderClosedException;
 import javax.mail.MessagingException;
 import javax.mail.internet.InternetAddress;
 
@@ -142,11 +141,6 @@ public class Helper {
     }
 
     static String formatThrowable(Throwable ex) {
-        if (ex instanceof FolderClosedException)
-            return null;
-        if (ex instanceof IllegalStateException)
-            return null;
-
         StringBuilder sb = new StringBuilder();
         sb.append(ex.getMessage() == null ? ex.getClass().getName() : ex.getMessage());
         Throwable cause = ex.getCause();

app/src/main/java/eu/faircode/email/ServiceSynchronize.java

@@ -965,6 +965,10 @@ public class ServiceSynchronize extends LifecycleService {
 
                         if (!istore.isConnected())
                             throw new StoreClosedException(istore);
+
+                        for (EntityFolder folder : folders.keySet())
+                            if (!folders.get(folder).isOpen())
+                                throw new FolderClosedException(folders.get(folder));
                     }
                     Log.i(Helper.TAG, account.name + " done running=" + state.running);
                 } finally {