From 935ef6fcd1b1b7ca3b219f79f49074f7eaa45c17 Mon Sep 17 00:00:00 2001 From: Thomas Basler Date: Thu, 17 Apr 2025 22:12:54 +0200 Subject: [PATCH] Fix: Prevent unpredicted behavior on overflows of millis() --- lib/TimeoutHelper/src/TimeoutHelper.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/TimeoutHelper/src/TimeoutHelper.cpp b/lib/TimeoutHelper/src/TimeoutHelper.cpp index 3f00c2bc..ce4ec232 100644 --- a/lib/TimeoutHelper/src/TimeoutHelper.cpp +++ b/lib/TimeoutHelper/src/TimeoutHelper.cpp @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* - * Copyright (C) 2022 Thomas Basler and others + * Copyright (C) 2022-2025 Thomas Basler and others */ #include "TimeoutHelper.h" #include @@ -29,5 +29,5 @@ void TimeoutHelper::reset() bool TimeoutHelper::occured() const { - return millis() > (startMillis + timeout); -} \ No newline at end of file + return millis() - startMillis > timeout; +}