Mirrors/FairEmail
1
0
Fork 0
mirror of https://github.com/M66B/FairEmail.git synced 2025-12-27 08:01:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

Safely reference parent fragment from adapters

Browse Source
This commit is contained in:
M66B
2019-07-01 09:30:07 +02:00
parent 0d5b1e2bac
commit 72db63e979
26 changed files with 303 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
app/src/main/java/eu/faircode/email/AdapterRule.java
View File

@@ -33,7 +33,11 @@ import android.widget.TextView;
import androidx.annotation.NonNull;
import androidx.appcompat.widget.PopupMenu;
import androidx.fragment.app.Fragment;
import androidx.lifecycle.Lifecycle;
import androidx.lifecycle.LifecycleObserver;
import androidx.lifecycle.LifecycleOwner;
import androidx.lifecycle.OnLifecycleEvent;
import androidx.localbroadcastmanager.content.LocalBroadcastManager;
import androidx.recyclerview.widget.DiffUtil;
import androidx.recyclerview.widget.ListUpdateCallback;
@@ -51,10 +55,10 @@ import java.util.List;
import javax.mail.MessagingException;
public class AdapterRule extends RecyclerView.Adapter<AdapterRule.ViewHolder> {
private Fragment parentFragment;
private Context context;
private LifecycleOwner owner;
private LayoutInflater inflater;
private View parentView;
private List<TupleRuleEx> items = new ArrayList<>();
@@ -262,7 +266,7 @@ public class AdapterRule extends RecyclerView.Adapter<AdapterRule.ViewHolder> {
@Override
protected void onExecuted(Bundle args, Integer applied) {
Snackbar.make(
parentView,
parentFragment.getView(),
context.getString(R.string.title_rule_applied, applied),
Snackbar.LENGTH_LONG).show();
}
@@ -281,12 +285,23 @@ public class AdapterRule extends RecyclerView.Adapter<AdapterRule.ViewHolder> {
}
}
AdapterRule(Context context, LifecycleOwner owner, View parentView) {
this.context = context;
this.owner = owner;
AdapterRule(Fragment parentFragment) {
this.parentFragment = parentFragment;
this.context = parentFragment.getContext();
this.owner = parentFragment.getViewLifecycleOwner();
this.inflater = LayoutInflater.from(context);
this.parentView = parentView;
setHasStableIds(true);
owner.getLifecycle().addObserver(new LifecycleObserver() {
@OnLifecycleEvent(Lifecycle.Event.ON_DESTROY)
public void onDestroyed() {
Log.i(AdapterRule.this + " parent destroyed");
AdapterRule.this.parentFragment = null;
AdapterRule.this.context = null;
AdapterRule.this.owner = null;
}
});
}
public void set(@NonNull List<TupleRuleEx> rules) {